FB1501 Regex string conversion #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
approved these changes
Jan 25, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds a separate method for string conversion for regex operations. The changes were validated by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Running manual validation using dev rule editor using positive datasets.
- Running manual validation using dev rule editor using negative datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the type_insensitive logic that was needed for #1414 from the string conversion used in the regex operations. This is because the strip() call causes fb1501 rule to not work.
to test: rerun fb1501