1345: correctly preprocess supp and relrec datasets #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-relrec-datasets
alexfurmenkov
changed the title
SFJohnson24
requested changes
Jan 20, 2026
Collaborator
SFJohnson24
left a comment
SFJohnson24
left a comment
There was a problem hiding this comment.
this looks good--can you make 1 test in tests/unit/test_dataset_preprocessor for the SUPPDM logic? I appreciate the regression tests but want this also in the unittests
…nd-relrec-datasets' into 1345-correctly-preprocess-supp-and-relrec-datasets
SFJohnson24
approved these changes
Jan 23, 2026
Collaborator
SFJohnson24
left a comment
SFJohnson24
left a comment
There was a problem hiding this comment.
PR adds improved suppDM relrec handling. Behaves as expected, adds regression test and unit tests
RamilCDISC
approved these changes
Jan 26, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR fixes the preprocessing for supp and relrec datasets. The validation was done by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring new testing cover required test cases.
- manual validation using rule editor with positive and negative dataset.
- Manual validation using CLI with postive and negative dataset.
- Running and ensuring the new regression test.
SFJohnson24
deleted the
1345-correctly-preprocess-supp-and-relrec-datasets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.