Conversation
|
This PR does not contain all the improvements mention in CDAP-18634. @sawantpritam Are they missed or its intentional? |
|
@itsankit-google commited remaining changes from CDAP-18634. |
| * Use either {@link io.cdap.e2e.utils.CdfHelper#openSinkPluginPreviewData(String)} | ||
| * or {@link io.cdap.e2e.utils.CdfHelper#openSourcePluginPreviewData(String)} as per plugin type. | ||
| */ | ||
| public static void clickPreviewData() { |
There was a problem hiding this comment.
Added annotations
| /** | ||
| * JsonUtils contains the json helper functions. | ||
| */ | ||
| public class JsonUtils { |
There was a problem hiding this comment.
Where is this class getting used?
There was a problem hiding this comment.
HTTP test scenarios. In HTTP plugin properties Schema needs to be entered manually(passing it from properties file as jsonArray). This will also be used in other plugins to pass expected schema.
| /** | ||
| * CommonUtils contains the e2e test helper functions. | ||
| */ | ||
| public class CommonUtils { |
There was a problem hiding this comment.
Can we rename it to PluginPropertyUtils? @rmstar what do you think?
There was a problem hiding this comment.
Renamed to PluginPropertyUtils
|
|
||
| @FindBy(how = How.XPATH, using = "//*[@data-cy='plugin-properties-validate-btn']") | ||
| @FindBy(how = How.XPATH, using = "//*[@data-cy='plugin-validation-success-msg']") | ||
| public static WebElement successMessage; |
There was a problem hiding this comment.
successMessage->validationSuccessMessage
sawantpritam
force-pushed
the
common_utils
branch
from
ec4ffed to
1a9a55a
Compare
| public static List<WebElement> inputSchemaDataTypes; | ||
|
|
||
| @FindBy(how = How.XPATH, using = "(//h2[text()='Input Records']/parent::div/div/div/div/div)[1]//div[text()!='']") | ||
| public static List<WebElement> previewInputRecordColumnNames; |
There was a problem hiding this comment.
Can we move all the preview related locators to CdfStudioLocators?
There was a problem hiding this comment.
Moved to CdfStudioLocators
|
@itsankit-google https://cdap.atlassian.net/browse/CDAP-18640 also added in this PR. |
| * Represents BigQuery Client | ||
| */ | ||
| public class GcpClient { | ||
| public class BigQueryClient { |
There was a problem hiding this comment.
This change will effect SAP ODP PR as well, data-integrations/sap#10.
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
LGTM. Please make the changes in respective plugin PRs affected by this PR. Can take one PR at a time as discussed.
|
@itsankit-google added minor change(comments added in properties file) https://cdap.atlassian.net/browse/CDAP-18638 |
| public static File file; | ||
|
|
||
| @Before | ||
| @Before(order = 0) |
There was a problem hiding this comment.
why do we need this change?
There was a problem hiding this comment.
We are going to add @Before & @After hooks in plugin repos as well to setup test prerequisite like creating source/target gcs buckets , source/target BQ tables. This order here is required to make sure that framework level @Before method runs first.
3 participants
@tivv @rmstar @itsankit-google Please review.
https://cdap.atlassian.net/browse/CDAP-18635
https://cdap.atlassian.net/browse/CDAP-18634
and few additional util methods added.