Open
Conversation
poojantcs
commented
Jan 20, 2025
| return !(isRunning()); | ||
|
|
||
| try { | ||
| Thread.sleep(5000); // Wait for 5 second after the refresh |
Contributor
Author
There was a problem hiding this comment.
Had to use the static wait as there are multiple threads running in parallel and UI responsiveness can introduce unwanted failures
Member
There was a problem hiding this comment.
can we move this to constant class?
Member
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
please revert unintended checkstyle changes.
Also RetryUtils#retry was also running a loop and retrying the operation? What is changing now?
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| } | ||
|
|
| // Wait for the Pipeline run to complete for the default timeout | ||
| WaitHelper.waitForElementToBeHidden(CdfPipelineRunLocators.runningStatus); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
Member
There was a problem hiding this comment.
can we properly log the error?
| try { | ||
| Thread.sleep(5000); // Wait for 5 second after the refresh | ||
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); |
| return !(isRunning()); | ||
|
|
||
| try { | ||
| Thread.sleep(5000); // Wait for 5 second after the refresh |
Member
There was a problem hiding this comment.
can we move this to constant class?
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
|
|
AnkitCLI
force-pushed
the
refreshPageTillPipelineRuns
branch
9 times, most recently
from
1434b9f to
bbaa359
Compare
AnkitCLI
force-pushed
the
refreshPageTillPipelineRuns
branch
from
ec41659 to
43c923b
Compare
AnkitCLI
force-pushed
the
refreshPageTillPipelineRuns
branch
from
7945125 to
7684b32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective: Refresh the pipeline run page if the status of the pipeline is stuck on UI. This is a workaround till the UI issue is fixed.
Summary of the changes: