Open
Conversation
segeljakt
approved these changes
Oct 4, 2023
Changes needed: * FunctionInterfaces.h has moved to the mlir/Interfaces/ directory. * FunctionOpInterface is now a subclass to CallableOpInterface, so getCallableRegion() has to be implemented for RustFuncOp and RustExtFuncOp. * The binop folder now supports poison, so we explicitly have to disable the poison support for our integer operations. * FlatSymbolRefAttr are now printed as template <...> arguments, so the test for rust.spawn has to be updated.
In rustc 1.72 identifier attributes inside macros are now methods and not plain values.
frej
force-pushed
the
frej/weekly-update
branch
from
f3ea938 to
75d169e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes needed:
FunctionInterfaces.h has moved to the mlir/Interfaces/ directory.
FunctionOpInterface is now a subclass to CallableOpInterface, so getCallableRegion() has to be implemented for RustFuncOp and RustExtFuncOp.
The binop folder now supports poison, so we explicitly have to disable the poison support for our integer operations.