Conversation
3ec2689 to
313eb64
Compare
xavierleune
commented
Mar 13, 2025
| "symfony/expression-language": "^6.3 || ^7.2", | ||
| "symfony/serializer": "^6.0 || ^7.0", | ||
| "symfony/security-bundle": "^6.0 || ^7.0", | ||
| "symfony/security-core": "^6.0 || ^7.0", |
Contributor
Author
There was a problem hiding this comment.
fun story: security-bundle@6.0 requires security-core ^5.4 | ^6.0 ; tests were perfectly fine when I added the User provider, even with lowest deps.
But it should not have been this way: the interface for the UserProvider was different in security-core 5.4 (loadByUsername became loadByIdentifier in 6.0). Tests were green even with security-core 5.4 ; but not anymore. So we lock the core at 6.0 minimum to avoid that.
Contributor
Author
|
@vgreb I changed requirements for ting at 3.11.0, tests will pass after the release of ting |
vgreb
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.