-
Notifications
You must be signed in to change notification settings - Fork 11
Nix use clash-compiler GHC version #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@martijnbastiaan CI seems to be failing over signatures, any clue as to why/how that works? |
|
No clue... If I'm to hazard a guess it's a temporary failure. Try again tomorrow? 🫠 |
2336df9 to
e2e7d07
Compare
|
The issue had to do with The upstream bug report: haskell-actions/setup#122 |
.github/workflows/ci.yml
Outdated
| matrix: | ||
| os: [ubuntu-latest] | ||
| cabal: ["3.6"] | ||
| cabal: ["3.16"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to just drop cabal entirely? I trust the action to figure out the right Cabal version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar enough with how github CI works to know what "dropping" exactly means hehe. I can set it to latest which would just follow the latest supported version of the Cabal. I think that would achieve the same goal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that should work :)
Rather than use a predefined local version of GHC, use the same version the clash compiler uses. This makes it so the flake doesn't have to get independently updated and can just follow whatever clash-compiler has. It also updates the cabal version of CI to a supported release. Cabal 3.6 supported was dropped ??? ago and it broke CI.
Rather than use a predefined local version of GHC, use the same version the clash compiler uses. This makes it so the flake doesn't have to get independently updated and can just follow whatever clash-compiler has.
This change has been made to following the decision to pin clash-compiler to a minor version of GHC. Changing minor versions for each project depending on clash-compiler will be tedious, so this will make it automatically follow the same version of clash-compiler.
Marked as draft until clash-lang/clash-compiler#2984 is merged.
TODO: