Add "Filter-Highlighted" Post Navigation Hotkeys#3262
Open
pentargency wants to merge 3 commits intoccd0:masterfrom
Open
Add "Filter-Highlighted" Post Navigation Hotkeys#3262pentargency wants to merge 3 commits intoccd0:masterfrom
pentargency wants to merge 3 commits intoccd0:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
I've been using the filter functionality for highlighting of posts relevant to my interests lately, and have wanted a good way to jump between filter-highlighted posts. I really like the way the QuoteYou jumping works with the default Alt+Up/Alt+Down hotkeys, so this was the basis of my expectations for similar filter-based functionality.
What
The expectation is that, should you have a comment filter like:
That you can then enter a thread on /lit/ discussing people's favorite authors, and press the "next filter-highlight" hotkey to receive either two outcomes:
How
Filter.coffeescript to duplicate the seek/scroll and "last highlighted post" memory functionality found withinQuoteYou.coffee.Filter.cb.seekmethod as appropriate when the hotkey is used.Testing
The extent of my testing is that I've loaded the resultant
4chan-x.user.jsv1.14.21.7-based userscript into my Violentmonkey v2.13.0 on Firefox 100.0 and tested that the following conditions are met: