-
-
Notifications
You must be signed in to change notification settings - Fork 257
Sync button component #2101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sync-boards-action
Are you sure you want to change the base?
Sync button component #2101
Conversation
src/components/Communicator/CommunicatorToolbar/SyncButton/SyncButton.component.js
Outdated
Show resolved
Hide resolved
src/components/Communicator/CommunicatorToolbar/CommunicatorToolbar.component.js
Show resolved
Hide resolved
src/components/Communicator/CommunicatorToolbar/CommunicatorToolbar.container.js
Outdated
Show resolved
Hide resolved
src/components/Communicator/CommunicatorToolbar/SyncButton/SyncButton.component.js
Outdated
Show resolved
Hide resolved
|
Great progress on the SyncButton! After reviewing the display state logic, I found a couple of issues we should address:
Suggestion: These two issues share the same root cause. We need a distinct "unsynced changes" visual state (different icon, color, or label) that works both offline and after reconnecting, and only clears once the sync actually completes successfully. Let me know if you have any doubt |
I'm thinking that maybe we can put an icon like this one without the text to show the pending unsynced changes when being online again: What do you think @RodriSanchez1 ? |
|
Yes it can be that one! It should be showed always that the user have local changes. No matters if is online or not |
The thing is that if the user is offline and has local changes it shows the working offline icon. If it's only offline it shows the offline icon. So we should replace the working offline icon with this one? I thought this one was only for when you have pending changes and are online |
|
Yes! I think that we should replace it! Copy the google docs funtionality behaviour |
…handling in SyncButton
…SyncButton with savedLocally
…omponent and update imports

Created a new
SyncButtoncomponent to theCommunicatorToolbar, providing improved visibility and control over board synchronization status. The changes also refactor how sync state is managed and displayed, replacing the previous spinner in the edit toolbar with a more informative sync button. Additionally, the sync status logic is enhanced to support multiple states and better offline handling.Sync functionality enhancements:
SyncButtoncomponent toCommunicatorToolbar, which visually communicates sync states (e.g., syncing, synced, pending, offline) and allows users to trigger sync actions.SyncButton, including Redux container, constants, messages, and CSS for styling and internationalization.Sync status logic improvements:
Board.constants.jsto add a newSYNCINGstatus, allowing for more granular sync state tracking.CommunicatorToolbarprops and Redux mapping to support new sync-related properties, includingisLoggedInand improved state selection.UI and code cleanup:
EditToolbar.component.jsand unnecessary imports, as sync status is now handled by the newSyncButton.CommunicatorToolbar.component.jsfor clarity and maintainability.