Implement board synchronization functionality #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hronization with remote boards
… boards and streamline dispatch logic
…s to reflect changes in board identification logic
…adLocalOnlyBoards to pass user data
…ation (#2098) * Add UPDATE_BOARDS_AFTER_RECONCILE action and handle in boardReducer * Add UPDATE_BOARDS_AFTER_RECONCILE action and update syncBoardsSuccess logic * Rename functions to better reflect their purpose and update related tests * Refactor syncBoardsSuccess test to remove unnecessary boards assignment
…RECONCILE action and updating reconcileAndMergeBoards to return detailed board states.
… test cases accordingly
…ards and updating tests accordingly
…andling and soft delete functionality in the reducer
Collaborator
Author
|
I use Claude Code to review the changes and I get:
Important Issues (Should Fix)
What's Done Well
Recommendations
|
tomivm
commented
Feb 4, 2026
| */ | ||
| export function applyRemoteChangesToState( | ||
| newRemoteBoards, | ||
| remoteNewerBoards, |
Collaborator
Author
There was a problem hiding this comment.
this names are confusing me
Collaborator
There was a problem hiding this comment.
Do you have any suggestion?
tomivm
commented
Feb 4, 2026
| continue; | ||
| } | ||
|
|
||
| if (moment(remote.lastEdited).isAfter(local.lastEdited)) { |
Collaborator
Author
There was a problem hiding this comment.
what happen if local is newer ?
Collaborator
There was a problem hiding this comment.
If the local board is newer will be pushed to the api as it gonna have the syncStatus: pending state
tomivm
commented
Feb 4, 2026
| applyRemoteChangesToState( | ||
| newRemoteBoards, | ||
| remoteNewerBoards, | ||
| remoteDeletedBoardIds |
Collaborator
Author
There was a problem hiding this comment.
i think would be great to use a object for params of this function. same for classifyRemoteBoards.
…ved clarity and functionality
…and enhance applyRemoteChangesToState tests for better coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance board synchronization by implementing the
syncBoardsaction, updating the reducer to manage sync status, and refining board identification logic. This update improves the handling of locally created boards and integrates detailed synchronization states. Tests have been adjusted to ensure accuracy in board classification and synchronization processes.NOTE: The original descriptionwas EDITED
Close #2096