Dynamic callback for Google and Facebook login#181
Open
Conversation
sylvansson
reviewed
Jul 9, 2021
martinbedouret
requested changes
Jul 19, 2021
…o fix/Google-and-Facebook-login-on-development
sylvansson
reviewed
Oct 31, 2021
Collaborator
sylvansson
left a comment
sylvansson
left a comment
There was a problem hiding this comment.
It'd be nice to have a test that checks that the right callback URL is called when we have a custom Referer header. You should be able to test this using something like nock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the error during login through Google and Facebook on development. It configures the callbackURL on passport auth using req.header.referer
After merging this the environmental variable FACEBOOK_CALLBACK_URL and GOOGLE_CALLBACK_URL are no more needed