Added CI pipeline for tests on Octave #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbm755
reviewed
Dec 4, 2025
cbm755
reviewed
Dec 4, 2025
cbm755
reviewed
Dec 4, 2025
cbm755
reviewed
Dec 4, 2025
cbm755
reviewed
Dec 4, 2025
cbm755
reviewed
Dec 4, 2025
cbm755
reviewed
Dec 4, 2025
| %!test | ||
| %!xtest | ||
| %! % upstream copy-on-write bug causes uminus to mutate input | ||
| %! % see workaround in @chebfun/uminus.m |
Owner
There was a problem hiding this comment.
Is this still a thing or not? Should this be a test or an xtest?
Collaborator
Author
There was a problem hiding this comment.
The COW fix is in the container, but not pushed to Octave yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built a Docker image for the patched version of Octave that I'm developing, and I wrote some basic CI logic to run the tests and produce a log file as an artifact. The Docker image is hosted on the GitHub Container Registry under my account and is publicly available. I'll try to keep it updated with the latest patches on my end.
I also had to manually specify all the test directories, because some of them (chebop, adchebfun) are way too buggy and I would have to disable tons of tests. Hopefully that'll be fixed soon.
If you want to actually use the patched Octave locally, you can use it using this command
It's built with optimizations, so it should be decently fast. Alternatively, if you want the Dockerfile itself, I can provide that too.