MWEs for chebfun and tests #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type of local functions are not supported in Octave (?) Maybe this is a temporary hack so don't re-indent code (this is to keep the diff smaller).
We cannot subclass double, which is causing lots of trouble for "domain" (which is only a very thin wrapper around double).
TEMPORARY workaround for some fight between between subsref and the .domain class property causing infinite loops.
Maybe this is just temporary? I'm sure this is used in other places so hopefully can fix it instead of working around with temp variables like is done here.
On Octave calling fieldnames on a classdef is a warning. Put that case last in chebfun/get so that we don't trigger the warning when accessing more common public properties. I assume this is not recommended OOP practice so probably this is a good chance on Matlab too. Or maybe it should raise a warning on Matlab?
This was mostly a thin wrapper around double, but it did have some methods that will probably need to be restored: "validate" and "merge" maybe others...?
Either this needs some workaround in subsref or perhaps its an Octave bug. I think there are subtle differences about how this sort of subsref chaining works b/w Octave and Matlab.
Owner
|
I cherry-picked the BIST file in commit 69a4d97. I'm going to try to change this to target the branch |
Owner
|
No, that didn't look very good. Leaving it as-is for reference; there are likely useful edits here. |
cbm755
force-pushed
the
octave_dev
branch
2 times, most recently
from
cf58e87 to
4f966f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.