Run specs in parallel, speed up CI, fix concurrency bugs in specs and code by apiology · Pull Request #1167 · castwide/solargraph

apiology · 2026-01-29T12:43:06Z

This allows rspec to use more than one CPU. Really useful on modern dev machines, and also useful in CI, where the default runner size has two CPUs.

See https://github.com/apiology/solargraph/pull/27/changes for a more useful diff and commentary

To do:

Track down slow tests and see where time is going
Track down rspec + rails specs slowness
Add developer doc on things to expect, how to write specs
Fix logging caching gems
Figure out where doc_map vs workspace fix went

Reduces the actual testing time in CI to about a minute using our small workers:

There are also a few fixes here:

For some reason, the debug level logging I tried to set in rspec wasn't persisting - this seems to do a better job and found a couple of bugs in the process that only reproduce at debug level logging.
Some tests didn't run individually, but did when run in sequence in the specs. We may see new failures pop up in the future; the trade-off for faster responsiveness is probably going to be less deterministic behavior in the face of buggy tests.

Includes for mergability:

2026-01-27 dev branch #1165

Includes this build fix:

Work around erb bundle problem with RBS pre-release #1168

Includes the fix for this bug, which parallel running seems to trigger (more often?):

Test verbosity fix #1166

Includes to show combined effect:

Spec performance fixes #1158

Includes transitively:

v0.59 branch

Some hand-changed fixes for RuboCop issues

…es_1

* Use each_line instead of text.lines Avoid allocating additional strings, instead use sliced substrings * gitignore vendor/cache * Remove redundant end_with? Co-authored-by: Jean Boussier <jean.boussier@gmail.com> * Remove benchamrks castwide#1054 (comment) * String#index(offset:) FTW 🚀 castwide#1054 (comment) Co-authored-by: Jean Boussier <jean.boussier@gmail.com> * fix rubocop --------- Co-authored-by: Jean Boussier <jean.boussier@gmail.com>

* Raise InvalidOffsetError for offsets > text * Linting * Fix fencepost error * Additional fencepost test * Document exception

On my machine, I got a 33% speed-up with these tweaks: before: Finished in 1 minute 15.88 seconds after: Finished in 49 seconds

@todos

* Fix merge * Adjust annotations * Fix typecheck errors * Fix merge * Fix merge * Fix some @sg-ignores * Fix merge * Merge branch 'intersection_types' into flow_sensitive_typing_2_0 * Fix RuboCop issue * Fix type issues * Fix type issues * Fix rspec.yml * Fix rspec.yml * Add @sg-ignores * Remove @sg-ignores * Merge branch 'or_support_in_flow_sensitive_typing' into union_type_enforcement * Fix spec * Fix annotations * Fix RuboCop issues * Bump RBS versions in rspec test * Fix version * Fix version matrix * Fix version matrix * Fix version matrix * Fix version matrix * Fix version matrix * Exclude another * Exclude another * Add version, fix doc * init -> config * Fix rbs-version for Ruby 4.0 in CI workflow * Clean up ruby-version entries in rspec.yml Removed deprecated ruby-version entries for RBS. * Fix RBS version for Ruby 4.0 in workflow * Fix merge * Improve signature combination Use our generated RBS signature from parameters as a key to combine method signatures from RBS/YARD pins. This is closer to what RBS does than the current technique of using the arity alone, and fixes a key degenerate case in Integer#+ revealed by updated definitions used by recently released RBS gems * Update annotations * Drop annotation * Fix RuboCop issue * Fix merge * Don't use solargraph-rspec branch * Fix merge * Debug * Add another use of stdlib dependencies in RBS * Mock additional call * Fix annotations * Update types in rspec undercover * Debug * Debug * Drop incorrect rbs collection use in spec * Update rubocop todo * Revert change * Fix RuboCop issue * Fix annotations * Fix annotations * RuboCop fix * Use "type arity" to guide signature combination * Update rubocop todo * Include return type arity in comparison * Add dodgy return type * Fix RuboCop issue * Add Ruby 4.0 jobs * Exclude another combo * Exclude another combo * Update rules to use report? * Fix merge * Fix merge * Drop dead code * Bump version to 0.59.0.dev.1 * Rename rule * Update RuboCop todo file * Update RuboCop todo file * Ratchet rubocop TODO file * Move to skip: * Mark spec as pending * Revert spec change * Drop old workaround * Fix merge * Fix typechecking issues * Revert doc * Fix spelling * Fix merge issue * Exclude the current gemspec from pins brought in from gem * Check pathname instead * Add sg-ignore * Avoid rbs pollution We were using the sig/shims directory for some internally helpful shims; unfortunately that exported them during gem installs, causing castwide#1144 * Test with RBS 4.0.0.dev.5 * Open up in gemspec * Fix missing spot * Typecheck using RBS prereleases * Move point of ignoring cached gems for gem projects * Fix issues resolving cgi escape functions * Be more careful marking things as stdlib * Reclassify rbs gem * Fix merge * Add sg-ignore * Fix merge * Remove outdated workaround * Fix @sg-ignore name * Restore workaround * Restore workaround * Merge branch 'flow_sensitive_typing_2_0' into 2025-01-06 * Fix method signature * Fix annotations * Add regression test and fix for issue found during future merge * Add regression test and fix for issue found during future merge * Fix merge * Fix merge * Fix merge * Fix merge * Use correct field for self type resolution Add a regression test and fix for self type resolution issue found on a future branch * Fix 'solargraph pin --references ClassName' private method call * Add error handling * Fix another location with another test case * Drop now-unneeded @sg-ignore * Don't log caching for each dependent library This causes duplicate logging on standard libraries, many of which are esoteric (e.g., "cgi-escaping"). The current method as of the 2025-01-06 branch would result in each stdlib library being cached individually. * Drop logging entirely * Fix some types based on future branch feedback * Provide Gem::Specification to outside interface * Provide Gem::Specification to outside interface * Use #to_spec * Provide Gem::Specification to outside interface * Fix typechecking error * Use consistent bundler versions * Fix type issue * Fix annotations based on future branch feedback * Add some @todos * Fix annotations * Fix annotations * Fix annotation * Add diff::lcs shim * Improve spec expectations * Add @sg-ignore * Fix rspec checks to run on all types of PRs * Fix merge * Fix merge * Fix merge

Let's work more directly with type objects and reduce duplication

apiology and others added 30 commits January 13, 2026 18:22

Manual rubocop fixes

620f60a

Some hand-changed fixes for RuboCop issues

Merge remote-tracking branch 'origin/master' into rubocop_manual_fixes_1

fbaa36a

Merge remote-tracking branch 'castwide/v0.59' into rubocop_manual_fix…

c958939

…es_1

RuboCop manual fixes

40e3b8d

RuboCop manual fixes

523d127

RuboCop manual fixes

1388af4

RuboCop manual fixes

f9590f1

RuboCop manual fixes

0fdb09f

RuboCop manual fixes

b3affb0

RuboCop manual fixes

68cd96d

RuboCop manual fixes

fecbb8e

RuboCop manual fixes

aed854a

RuboCop manual fixes

80b8e7b

Raise InvalidOffsetError for offsets > text (castwide#1155)

4c05f28

* Raise InvalidOffsetError for offsets > text * Linting * Fix fencepost error * Additional fencepost test * Document exception

Spec performance fixes

29fbd34

On my machine, I got a 33% speed-up with these tweaks: before: Finished in 1 minute 15.88 seconds after: Finished in 49 seconds

Add rbs collection in undercover run

70ea4bb

Add rbs collection in undercover run

8c049fb

Fix copy-and-paste-o

e428f80

Perform specific caching

ffc25d6

Merge remote-tracking branch 'castwide/v0.59' into speed_up_specs

79d9efb

Refactor RbsMap::Conversions

be2c6f5

Let's work more directly with type objects and reduce duplication

Release 0.58.2

676da4c

Complete other_type_to_type transition

504ba73

Refactor

608d64b

Refactor

9b15cfb

Refactor

5d9f761

Refactor

46f8063

Refactor

5d8ffc8

apiology added 30 commits February 6, 2026 11:26

Debug

2af160d

Drop extra /

53676c5

Debug

59b460d

Debug

b5bcd4b

Debug

dda8322

Debug

a82ab1a

Debug

f7b84a1

Debug

c5d86e3

Debug

25d01ef

Drop workers experimentation

73de5c5

Consistency fixes

25457a8

Drop @param

3e85551

Docs

d10e029

Drop debugging

a4bd2bd

Drop debugging

16fb502

Revert debugging

d707e04

Drop unneeded Config.new

b8b18c4

Revert updates

aa8979c

Fix annotation

fefdeba

Revert

792e857

Fix log message

23ccc34

Cache workspace gems in parallel

6e06cd2

Cache workspace gems in parallel

a1aeac2

Cache docmap gems in parallel

81b3ae0

Add --workspace flag, default to docmap caching

91b8852

Fix API break

013deaf

Fix nil issue

98953f7

Fix spec

e0b28e0

Cache more up front in rspec_specs

c6d7ea9

Drop unneeded nil case

1f599e9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Run specs in parallel, speed up CI, fix concurrency bugs in specs and code#1167

Run specs in parallel, speed up CI, fix concurrency bugs in specs and code#1167
apiology wants to merge 1562 commits intocastwide:v0.59from
apiology:parallel_rspec

apiology commented Jan 29, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

apiology commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

apiology commented Jan 29, 2026 •

edited

Loading