Open
Conversation
We were using the sig/shims directory for some internally helpful shims; unfortunately that exported them during gem installs, causing castwide#1144
* Use each_line instead of text.lines Avoid allocating additional strings, instead use sliced substrings * gitignore vendor/cache * Remove redundant end_with? Co-authored-by: Jean Boussier <jean.boussier@gmail.com> * Remove benchamrks castwide#1054 (comment) * String#index(offset:) FTW 🚀 castwide#1054 (comment) Co-authored-by: Jean Boussier <jean.boussier@gmail.com> * fix rubocop --------- Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
* Raise InvalidOffsetError for offsets > text * Linting * Fix fencepost error * Additional fencepost test * Document exception
Let's work more directly with type objects and reduce duplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's work more directly with type objects and reduce duplication
Includes