rubocop --unsafe-autocorrect changes#1156
Open
apiology wants to merge 1370 commits intocastwide:v0.59from
Open
rubocop --unsafe-autocorrect changes#1156apiology wants to merge 1370 commits intocastwide:v0.59from
apiology wants to merge 1370 commits intocastwide:v0.59from
Conversation
…:apiology/solargraph into fix_directive_combination_issue
…node_modules_stubs
Use our generated RBS signature from parameters as a key to combine method signatures from RBS/YARD pins. This is closer to what RBS does than the current technique of using the arity alone, and fixes a key degenerate case in Integer#+ revealed by updated definitions used by recently released RBS gems
6bab1bd to
7a71eed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon:
Takes the rubocop todo file down further - cumulative reduction is:
There are 363 lines left in that file.
This PR was generated by this script - rerun to autogenerate (the PR will collect conflicts pretty regularly until it's merged):
First, reset the branch to be the same as rubocop_a:
Manually fix typechecking errors reported in CI
Check in fixes if they pass
The solargraph overcommit errors are limitations in our strong typechecking, mostly if not all addressed by other open PRs.
After this PR is merged, other PRs will need to do the 'Apply the autocorrect' step before merging master in to make that merge happen smoothly.