Don't log caching for each dependent library#1151
Open
apiology wants to merge 758 commits intocastwide:masterfrom
Open
Don't log caching for each dependent library#1151apiology wants to merge 758 commits intocastwide:masterfrom
apiology wants to merge 758 commits intocastwide:masterfrom
Conversation
…ric_typechecking_improvements
…ing_merge Or support in flow sensitive typing merge
Add a regression test and fix for self type resolution issue found on a future branch
This causes duplicate logging on standard libraries, many of which are esoteric (e.g., "cgi-escaping"). The current method as of the 2025-01-06 branch would result in each stdlib library being cached individually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an integration issue between different branches.
We are now logging things entirely in PinCache and don't need to log additionally in RbsMap::StdlibMap, much less for each dependent library as well as the one being cached.
This is based on the 2026-01-06 branch.