Skip to content

Conversation

@kirkins
Copy link

@kirkins kirkins commented Mar 11, 2017

I often found I wanted to look through my history using this but would search every-time.

I wanted to be able to do something like this:

https://kirkins.github.io/github-activity/?user=kirkins

So I figured I'd send a pull request. Though I realize this may just be adding an unneeded feature to something meant to be an mvp.

Best,
Philip

@kirkins
Copy link
Author

kirkins commented Mar 11, 2017

P.S. I'm only changing the gh-pages branch not modifying the base library like the other open pull-request.

@turquoise-turtle
Copy link

turquoise-turtle commented Apr 30, 2018

Just a suggestion, you could use:

var parsedUrl = new URL(window.location.href);

var username = parsedUrl.searchParams.get('url');

And then use if statements to put in the default

@ypid
Copy link

ypid commented May 21, 2018

PS: https://github.com/colmdoyle/gh-activity supports this: https://cdoyle.me/gh-activity/gh-activity.html?user=ypid&type=user :)

@caseyscarborough
Copy link
Owner

I like this idea a lot. I think it could be implemented a little more cleanly using @turquoise-turtle's solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants