Skip to content

Conversation

@sheraaronhurt
Copy link
Contributor

@sheraaronhurt sheraaronhurt commented Dec 8, 2025

responding to #1938 (comment)

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1950

The following changes were observed in the rendered markdown documents:


What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-12-17 20:21:57 +0000

github-actions bot pushed a commit that referenced this pull request Dec 8, 2025
github-actions bot pushed a commit that referenced this pull request Dec 8, 2025
Copy link
Member

@brownsarahm brownsarahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also be updated on the checkout page.

@ndporter
Copy link
Contributor

ndporter commented Dec 17, 2025

this should also be updated on the checkout page.

This was resolved by #1952 and #1955 but the language in this PR is still a little better now the conflict is resolved. Can you mark the changes approved @brownsarahm so it can be merged?

github-actions bot pushed a commit that referenced this pull request Dec 17, 2025
@brownsarahm brownsarahm merged commit 1cea415 into main Dec 17, 2025
3 checks passed
@brownsarahm brownsarahm deleted the sheraaronhurt-patch-7 branch December 17, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants