Draft
Conversation
tintinthong
reviewed
Sep 29, 2022
|
|
||
| try { | ||
| await withTempFile(async (file) => { | ||
| await fs.writeFile(file, data); |
Contributor
There was a problem hiding this comment.
This error is received
The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Object
data filed here is of the form object. It can be converted via JSON.stringify(data)
Contributor
There was a problem hiding this comment.
probably we want to add a type guard first before we stringify it.maybe lodash's isPlainObject https://lodash.com/docs/4.17.15#isPlainObject
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May work in cases current implementation doesn't just due to random implementation differences