Use a single room per server-user pair for events by IanCal · Pull Request #3910 · cardstack/boxel

IanCal · 2026-01-27T14:54:46Z

Currently we require that every realm-user pair has a unique room.

Instead, we can have a single server user, and a single dm room for events between the server and user. Indexing events have realm URLs added so that the host can correctly identify which realm to update.

Since users have just one session room, this has been added as a column on the users table and the session_rooms table has been removed.

We also now only notify users that have read or write access to a realm if they are explicitly identified in the permissions.

Most of the changes are in tests to make sure that users are created and have the right access, partly to handle the hard coded details in the realm server about owners.

…realm-server-session

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7cd147b2c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-27T15:00:13Z

packages/runtime-common/db-queries/session-room-queries.ts

+    'JOIN realm_user_permissions rup',
+    'ON rup.username = sr.matrix_user_id',
+    'WHERE rup.realm_url =',
    param(realmURL),
+    'AND (rup.read = true OR rup.write = true)',


Include public permissions when selecting session rooms

This query now only returns session rooms for users that have explicit realm_user_permissions rows (it joins on rup.username = sr.matrix_user_id). For realms that are world‑readable via the '*' permission row, users who only have public access will not match this join, so fetchAllSessionRooms returns no rooms for them. Because NodeAdapter.broadcastRealmEvent relies on this mapping, those public users will stop receiving realm events (e.g. incremental index invalidations) even though they can read the realm. This regression happens specifically for realms that are readable via '*' but have no per‑user permission rows.

Useful? React with 👍 / 👎.

Yes. Only specifically mentioned users with read or write access are now going to be notified of updates. This is an expected and OK change. Pinging all users if we change catalog could be a huge issue, and should be solved in a different way so this drop of functionality is expected.

github-actions · 2026-01-27T15:02:12Z

Preview deployments

github-actions · 2026-01-27T15:14:05Z

Host Test Results

1 files ± 0 1 suites ±0 5h 56m 13s ⏱️ + 4h 17m 38s
1 849 tests + 12 1 794 ✅ - 30 13 💤 ± 0 1 ❌ + 1 41 🔥 +41
3 671 runs +1 819 3 562 ✅ +1 723 26 💤 +13 42 ❌ +42 41 🔥 +41

For more details on these failures and errors, see this check.

Results for commit 9086d4f. ± Comparison against base commit c9b3642.

This pull request removes 9 and adds 21 tests. Note that renamed tests count towards both.

Chrome ‑ Acceptance | interact submode tests > 1 stack: clicking a linked file opens it as a new isolated stack item
Chrome ‑ Integration | card-basics > cards allowed to be edited: linksTo FileDef renders without editor controls in edit format
Chrome ‑ Integration | card-basics > cards allowed to be edited: linksToMany FileDef renders without editor controls in edit format
Chrome ‑ Unit | index-writer: can get compiled module and source from WIP index
Chrome ‑ Unit | index-writer: can get compiled module and source when requested with file extension
Chrome ‑ Unit | index-writer: can get compiled module and source when requested without file extension
Chrome ‑ Unit | index-writer: can get error doc for module
Chrome ‑ Unit | index-writer: can perform invalidations for a module entry
Chrome ‑ Unit | index-writer: returns undefined when getting a deleted module

Chrome ‑ Acceptance | code submode | head format preview: does not show warning when head template only has allowed tags
Chrome ‑ Acceptance | code submode | head format preview: shows warning when head template contains disallowed tags
Chrome ‑ Acceptance | code submode | inspector tests: "in-this-file" panel displays FileDef declarations with correct labeling
Chrome ‑ Acceptance | code submode | inspector tests: Schema/Playground/Spec panes render for a focused FileDef declaration
Chrome ‑ Acceptance | file chooser tests: can link a file via the chooser
Chrome ‑ Acceptance | file chooser tests: clicking a linked file opens it as a new isolated stack item
Chrome ‑ Acceptance | file chooser tests: file chooser filters by type when field is ImageDef
Chrome ‑ Acceptance | file chooser tests: file chooser shows all files when field is FileDef
Chrome ‑ Global error: Uncaught Error: intentional error thrown at http://localhost:7357/assets/chunk.b1e276f78ce231c0029c.js, line 93736  While executing test: Integration | Store: can capture error when auto saving 
Chrome ‑ Integration | card-basics > cards allowed to be edited: linksTo FileDef renders editor controls in edit format
…

♻️ This comment has been updated with latest results.

…realm-server-session

packages/realm-server/handlers/handle-publish-realm.ts

…users are created in the test setup

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 289cf14ced

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-17T17:09:09Z

packages/host/app/services/matrix-service.ts

+      const content = event.content as RealmEventContent;
+      if (!content.realmURL) {
        realmEventsLogger.debug(
-          'Ignoring realm event because no realm found',
+          'Ignoring realm event because no realm URL was provided',
          event,
        );
-      } else {
-        if (realmResourceForEvent.info?.realmUserId !== event.sender) {
-          realmEventsLogger.warn(
-            `Realm event sender ${event.sender} is not the realm user ${realmResourceForEvent.info?.realmUserId}`,
-            event,
-          );
-        }
-
-        (event.content as any).origin_server_ts = event.origin_server_ts;
-        this.messageService.relayRealmEvent(
-          realmResourceForEvent.url,
-          event.content as RealmEventContent,
-        );
+        return;
      }
+
+      (content as any).origin_server_ts = event.origin_server_ts;
+      this.messageService.relayRealmEvent(content);


Reject realm events from non-session rooms

processDecryptedEventFromAuthRoom now relays any APP_BOXEL_REALM_EVENT_TYPE event as long as content.realmURL exists, but this path is reached for every non-AI room event. That means a participant in any unrelated DM/group room can send a crafted realm event and trigger invalidations for whatever realm URL the client is subscribed to. Previously this code first resolved event.room_id to a known session room before relaying, so removing that check introduces spoofable cross-room realm updates.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-17T17:09:09Z

packages/runtime-common/db-queries/session-room-queries.ts

+  if (rows.length === 0) {
+    throw new Error(
+      `Cannot set session room for user ${matrixUserId}: user does not exist in the users table`,
+    );


Handle missing users when persisting session rooms

upsertSessionRoom now throws when the matrix user has no users row, and Realm's /_session login flow calls this path during session creation. For first-time/non-provisioned matrix users, this turns session creation into a 500 instead of issuing a JWT (or a controlled 4xx), which is a regression from the previous upsert behavior that created session-room mappings independently of users rows.

Useful? React with 👍 / 👎.

habdelra

looks good. I assume this change is not backwards compatible, meaning that we'll need to abandon AI conversations that were created from before this is merged?

IanCal · 2026-02-18T10:53:04Z

looks good. I assume this change is not backwards compatible, meaning that we'll need to abandon AI conversations that were created from before this is merged?

I think it's mostly backwards compatible, this doesn't touch how the ai conversations work, and the session rooms are (relatively) ephemeral anyway. If the session room we create for login is in existing users dms then they should already be in the room we'll use for indexing events, if not they won't get them until they get a new jwt.

…o-session-rooms.js

IanCal added 6 commits December 23, 2025 20:53

Don't link to staging

a72e992

Simplify setup to require a single session room for all comms

fd6228f

Add realm url to indexing events

d920670

Merge branch 'main' into cs-9552-refactor-realm-event-sending-to-use-…

505c1e5

…realm-server-session

Remove username from publishing realm

7bc0935

Remove console logging

7cd147b

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

IanCal marked this pull request as draft January 27, 2026 15:08

IanCal added 20 commits February 3, 2026 14:47

Merge branch 'main' into cs-9552-refactor-realm-event-sending-to-use-…

789ce5c

…realm-server-session

Pass through matrix client in tests setup too

02f9b25

Merge branch 'main' into cs-9552-refactor-realm-event-sending-to-use-…

45d3741

…realm-server-session

Update scheme and move migration to be the last

0d138a1

Explicitly expect two files to be attached

2854b71

Don't auto-login to realm

cfbbae5

Add the hard coded realm user to have read permissions

10aaba6

Session rooms are created automatically, do not create them in tests

0740430

Update permissions in tests

01b7c9f

Use the realm user id to get the session rooms for sending events

6a2a5bd

Info overwriting removed, correct realm url

e811ac5

Remove accidental test.only

cc60f93

Merge branch 'main' of github.com:cardstack/boxel

036d8e3

Merge branch 'main' into cs-9552-refactor-realm-event-sending-to-use-…

79409bc

…realm-server-session

Fix syntax

1afb5ae

node test realm is the owner

5cb89d1

fix syntax error

801d6d1

syntax error

eea7e1f

JWTs need to have matching permissions, add test realm user as owner

b3473df

Remove extra user, remove unnecessary filesystem content

f501fe0

IanCal added 5 commits February 11, 2026 16:23

Import fix

a495154

Restore import as it was earlier

fb458c4

Index events contain realm url

a231047

Realm server is realm user

1974d26

Lint

6a5402e

IanCal commented Feb 16, 2026

View reviewed changes

packages/realm-server/handlers/handle-publish-realm.ts Outdated Show resolved Hide resolved

IanCal added 15 commits February 16, 2026 16:24

Move the session room to the users table now that it is 1:1

5ff6b80

Restore realm bot user for published realms

5ada8be

Require realm urls in events, add new ones for file watching

d676caa

Event test updates

ce8f3d3

Update session room work in tests

1a4c9dc

Require that sessions are only created for users that exist and that …

9c7ef14

…users are created in the test setup

Update schema

ed163c7

Can't have too many 0s in your migration filename

1fc0b8c

Don't login without the user existing

f0ed61b

Make sure users exist at the correct points in tests

822c36c

Add user in CLI tests

5418d39

Specify username

c088fa7

Linting

18a8d61

Only create dm rooms for users that exist in the table already

abfe929

Linting

289cf14

IanCal marked this pull request as ready for review February 17, 2026 16:57

IanCal requested review from a team and lukemelia February 17, 2026 17:04

chatgpt-codex-connector bot reviewed Feb 17, 2026

View reviewed changes

habdelra approved these changes Feb 17, 2026

View reviewed changes

Only create session rooms when users exist for now

9086d4f

IanCal added 2 commits February 19, 2026 15:23

Don't remove the sessions table

5b3d296

Delete packages/postgres/migrations/1770648743000_add-realm-user-id-t…

daa217a

…o-session-rooms.js

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Use a single room per server-user pair for events#3910

Use a single room per server-user pair for events#3910
IanCal wants to merge 53 commits intomainfrom
cs-9552-refactor-realm-event-sending-to-use-realm-server-session

IanCal commented Jan 27, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Jan 27, 2026

Uh oh!

IanCal Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 17, 2026

Uh oh!

chatgpt-codex-connector bot Feb 17, 2026

Uh oh!

habdelra left a comment

Uh oh!

IanCal commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

IanCal commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

IanCal Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 27, 2026

Preview deployments

Uh oh!

github-actions bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Host Test Results

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

habdelra left a comment

Choose a reason for hiding this comment

Uh oh!

IanCal commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IanCal commented Jan 27, 2026 •

edited

Loading

github-actions bot commented Jan 27, 2026 •

edited

Loading