This repository was archived by the owner on Jan 12, 2019. It is now read-only.
Open
Conversation
- focus progress is now also visible - detect card frame borders get hidden when focus score is to low
Contributor
Author
|
Note: The build only fails because the required DMZ changes cannot be fetched since they are not merged yet: card-io/card.io-dmz#30 |
| int width = (int) (GUIDE_STROKE_WIDTH / 2 * mScale); | ||
| int height = (int) (50 * mScale); | ||
| int offset = (int) (10 * mScale); | ||
| for ( int i = 0; i < scanProgress; i++) { |
Member
There was a problem hiding this comment.
The spacing is not consistent. Don't put a space before int.
Contributor
Author
|
Maybe we leave the color of the guide frame as defined (GREEN) and do the fancy color effect just on the progress bar... Note: The build still fails because the required DMZ changes cannot be fetched yet since they are unmerged: card-io/card.io-dmz#30 |
* progress color only applied to progress indicator bar * progress indicator bar elements are now incremential
Contributor
Author
|
Like this. Updated the progress color behavior. Guide frame color is now unchanged. Note: The build still fails because the required DMZ changes cannot be fetched yet since they are unmerged: card-io/card.io-dmz#30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's helpful to track the scan progress state (focus, edge, vseg, hseg, stability...).
It enables additional functionality like visible user feedback guidance
or autofocus trigger once hseg is reached which I have also put
in the pull requests (dmz and android).
This increases user experience because: