Refactor Result internals (currently experimental), Introduce Either monad and better match #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from pnpm to bun package manager, add oxlint configuration with comprehensive rules, update biome settings, and restructure build configuration. Minor code improvements include import path fix and new flip() method in Result class.
Update development environment configurations to disable vitest typechecking and configure Zed language servers for TypeScript development.</think> Add vitest typecheck config and Zed editor settings Update development environment configurations to disable vitest typechecking and configure Zed language servers for TypeScript development.
Migrate all test files from Node.js test runner to Bun's test framework, replacing assert statements with expect matchers and mock functions. Simplify HybridResult implementation by removing Phase 2+ combinators (map, flatMap, zip, validate, etc.) while keeping core Phase 1 API (Ok/Err constructors, unwrap, isOk/isErr, flip, toPromise, try).
Update tests to expect UnwrappedOkWithErr instead of specific error types when unwrapping. Remove unnecessary async wrappers in expect statements and add checks for original error types.
Add type assertions for error arrays and handle async error unwraping properly in test assertions.</think> <think></think> Fix error handling in hybrid result tests Add explicit type assertions for error arrays and update async error assertions to properly handle Promise rejections.
🦋 Changeset detectedLatest commit: 67ce32a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.