Skip to content

Comments

Update to support node LTS versions#206

Merged
captbaritone merged 2 commits intocaptbaritone:mainfrom
edvinerikson:feature/node-lts
Dec 10, 2025
Merged

Update to support node LTS versions#206
captbaritone merged 2 commits intocaptbaritone:mainfrom
edvinerikson:feature/node-lts

Conversation

@edvinerikson
Copy link
Contributor

Summary

This PR updates our CI workflows to run tests only on Node.js LTS and the current stable (non-LTS) release. It also updates the engines field to require Node.js >= 20.x, aligning with the latest LTS version.

Rationale

Most enterprise environments I’ve worked with rely heavily on LTS releases of Node.js. Since those versions are the most relevant in production, focusing our test matrix on LTS provides clearer, more meaningful feedback.
Including the current stable (non-LTS) release gives us early visibility into potential breaking changes without expanding the test matrix unnecessarily.

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for grats ready!

Name Link
🔨 Latest commit bacada7
🔍 Latest deploy log https://app.netlify.com/projects/grats/deploys/6937c02478517e0008ddb04e
😎 Deploy Preview https://deploy-preview-206--grats.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@captbaritone
Copy link
Owner

I tried running the CI on this PR. Looks like building the docs website fails on Node 25?

@edvinerikson
Copy link
Contributor Author

I couldn't figure out how to fix the issue. What happened was that some codepath in the server bundle executed localStorage.getItem(). The codepath had checks for seeing if localStorage is defined, so my guess is that something polyfills localStorage with a non-compatible polyfill.

I removed node 25 for now.

@captbaritone captbaritone merged commit 85ecf27 into captbaritone:main Dec 10, 2025
14 checks passed
@edvinerikson edvinerikson deleted the feature/node-lts branch December 10, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants