chore: make typescript a peerDependency#187
Open
radiosilence wants to merge 1 commit intocaptbaritone:mainfrom
Open
chore: make typescript a peerDependency#187radiosilence wants to merge 1 commit intocaptbaritone:mainfrom
radiosilence wants to merge 1 commit intocaptbaritone:mainfrom
Conversation
❌ Deploy Preview for grats failed. Why did it fail? →
|
Owner
|
Sorry I missed this. I know the problem you're highlighting, but I'm a little hesitant to take this on since there are places where we do poke (lightly) into private TypeScript APIs and I don't know that we can reliably trust those to behave stably on all versions of TypeScript. That said, I like the idea of making both I think a prerequisite for this would be to get our CI tests to run with several versions of TypeScript so that we can validate that we actually can safely run with arbitrary versions of TypeScript. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinning the internal version can cause havok when running
npx grats, due various flags/configurations oftsconfig.jsonnot being supported by older TS versions.