Skip to content

Comments

chore: make typescript a peerDependency#187

Open
radiosilence wants to merge 1 commit intocaptbaritone:mainfrom
radiosilence:patch-1
Open

chore: make typescript a peerDependency#187
radiosilence wants to merge 1 commit intocaptbaritone:mainfrom
radiosilence:patch-1

Conversation

@radiosilence
Copy link

Pinning the internal version can cause havok when running npx grats, due various flags/configurations of tsconfig.json not being supported by older TS versions.

@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for grats failed. Why did it fail? →

Name Link
🔨 Latest commit d8cf01e
🔍 Latest deploy log https://app.netlify.com/projects/grats/deploys/686fdfe26bee230008931520

@captbaritone
Copy link
Owner

Sorry I missed this. I know the problem you're highlighting, but I'm a little hesitant to take this on since there are places where we do poke (lightly) into private TypeScript APIs and I don't know that we can reliably trust those to behave stably on all versions of TypeScript.

That said, I like the idea of making both graphql and typescript peer dependencies long term since one of the values of Grats is that it has so few dependencies and the ones that are actually heavy are surely already dependencies you have.

I think a prerequisite for this would be to get our CI tests to run with several versions of TypeScript so that we can validate that we actually can safely run with arbitrary versions of TypeScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants