setUserId accept null too #49#50
Open
markxoe wants to merge 3 commits intocapacitor-community:masterfrom
Open
Conversation
|
Any update on this PR? I am also waiting on this fix |
Member
|
I have some time set aside later this week for this. |
|
Hi, I also need to unset the userId via setUserId. @brownoxford do you think you need help to merge this PR? |
|
@brownoxford @edouardruiz any updates? |
|
Also interested by this. Any news @brownoxford? |
|
@markxoe it seems your PR is not fixing the issue unfortunately. For example on iOS: firebase-analytics/ios/Plugin/Plugin.swift Lines 25 to 29 in 962a666 Since it expects a "string" it will raise an error in all cases. Did you test your implementation? (maybe I'm doing something wrong) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've solved #49 so that
nullwill be accepted bysetUserIdand in the web-version it gets converted to an empty string