Skip to content

fix(android): replace deprecated methods #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcesarmobile wants to merge 2 commits into from
Closed

fix(android): replace deprecated methods #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb6cb44
fix(android): replace deprecated methods
jcesarmobile Dec 4, 2025
1ee8e10
Merge branch 'master' into refactor
jcesarmobile Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions android/src/main/java/com/getcapacitor/community/firebaseanalytics/FirebaseAnalytics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,11 @@ public void setUserId(PluginCall call) {
call.reject(MISSING_REF_MSSG);
return;
}

if (!call.hasOption("userId")) {
String userId = call.getString("userId");
if (userId == null) {
call.reject("userId property is missing");
return;
}

String userId = call.getString("userId");
mFirebaseAnalytics.setUserId(userId);
call.resolve();
} catch (Exception ex) {
Expand All @@ -84,20 +82,18 @@ public void setUserProperty(PluginCall call) {
call.reject(MISSING_REF_MSSG);
return;
}

if (!call.hasOption("name")) {
String name = call.getString("name");
String value = call.getString("value");
if (name == null) {
call.reject("name property is missing");
return;
}

if (!call.hasOption("value")) {
if (value == null) {
call.reject("value property is missing");
return;
}

String name = call.getString("name");
String value = call.getString("value");

mFirebaseAnalytics.setUserProperty(name, value);
call.resolve();
} catch (Exception ex) {
Expand Down Expand Up @@ -149,14 +145,14 @@ public void setScreenName(final PluginCall call) {
return;
}

if (!call.hasOption("screenName")) {
final String screenName = call.getString("screenName");
final String nameOverride = call.getString("nameOverride");

if (screenName == null) {
call.reject("screenName property is missing");
return;
}

final String screenName = call.getString("screenName");
final String nameOverride = call.getString("nameOverride", null);

bridge
.getActivity()
.runOnUiThread(
Expand Down Expand Up @@ -218,12 +214,12 @@ public void logEvent(PluginCall call) {
return;
}

if (!call.hasOption("name")) {
String name = call.getString("name");
if (name == null) {
call.reject("name property is missing");
return;
}

String name = call.getString("name");
JSONObject params = call.getData().getJSObject("params");
mFirebaseAnalytics.logEvent(name, params != null ? FirebaseAnalytics.convertJsonToBundle(params) : null);
call.resolve();
Expand Down