Skip to content

Conversation

@muhammad-ali-pk
Copy link
Contributor

Done

  • Updated publish-on-release.yaml workflow to bundle and upload ESM to assets manager
  • Set up QA in pr.yaml workflow to test release workflow changes

QA

  • Verify the build-js and publish-assets actions succeed

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

@jmuzina jmuzina force-pushed the feat-upload-esm-to-cdn branch from 1dc66ea to af4c8d2 Compare December 1, 2025 20:03
Comment on lines 9 to 31
name: Build Vanilla CSS
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v4
with:
node-version: 18
- name: Read Vanilla version from package.json
run: |
node -p "require('./package.json').version" > VANILLA_VERSION
echo "Building Vanilla v$(cat VANILLA_VERSION)"
echo "Building Vanilla CSS v$(cat VANILLA_VERSION)"
- run: yarn install
- run: yarn build
- run: yarn test
- name: Show size of the build file
run: stat -c '%s' build/css/build.css
- run: cp VANILLA_VERSION build/css
- uses: actions/upload-artifact@v5
with:
name: css
path: build/css

build-js:
name: Build Vanilla JS
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants