-
Notifications
You must be signed in to change notification settings - Fork 186
feat: Build and upload vanilla ESM bundle to assets manager #5671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
muhammad-ali-pk
wants to merge
2
commits into
main
Choose a base branch
from
feat-upload-esm-to-cdn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a15efe to
1dc66ea
Compare
1dc66ea to
af4c8d2
Compare
Comment on lines
9
to
31
| name: Build Vanilla CSS | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18 | ||
| - name: Read Vanilla version from package.json | ||
| run: | | ||
| node -p "require('./package.json').version" > VANILLA_VERSION | ||
| echo "Building Vanilla v$(cat VANILLA_VERSION)" | ||
| echo "Building Vanilla CSS v$(cat VANILLA_VERSION)" | ||
| - run: yarn install | ||
| - run: yarn build | ||
| - run: yarn test | ||
| - name: Show size of the build file | ||
| run: stat -c '%s' build/css/build.css | ||
| - run: cp VANILLA_VERSION build/css | ||
| - uses: actions/upload-artifact@v5 | ||
| with: | ||
| name: css | ||
| path: build/css | ||
|
|
||
| build-js: | ||
| name: Build Vanilla JS | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
publish-on-release.yamlworkflow to bundle and upload ESM to assets managerpr.yamlworkflow to test release workflow changesQA
build-jsandpublish-assetsactions succeedCheck if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
[if relevant, include a screenshot or screen capture]