-
Notifications
You must be signed in to change notification settings - Fork 186
wip: feat(Tiered List): add media (images/videos) to the Tiered List pattern #5503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jmuzina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Holding off on final review until we have some opinions from design, but I've left some initial comments below.
templates/docs/examples/patterns/tiered-list/with-default-width-image.html
Outdated
Show resolved
Hide resolved
templates/docs/examples/patterns/tiered-list/with-default-width-image.html
Outdated
Show resolved
Hide resolved
templates/docs/examples/patterns/tiered-list/with-full-width-image.html
Outdated
Show resolved
Hide resolved
|
hi, great additon - thanks for suggesting it @muhammad-ali-pk. A few small things to polish:
|
|
I also need this for https://warthogs.atlassian.net/browse/WD-20400. @muhammad-ali-pk I hope you don't mind if I take this PR over :) |
|
@jmuzina Heyy, sorry I haven't been able to get back to it due to other high priority tasks :') |
|
@lyubomir-popov Wonder if I can have your thoughts on this design, which has as tiered list with an image, but it has two differences from the approach @muhammad-ali-pk took here:
If we can form solid opinions that this pattern should take on image positioning and sizing, this PR can move forward. |
|
@jmuzina My use-case required an image between the description and the list. |
@muhammad-ali-pk It's not a matter of "effort", it's moreso that when we are creating an upstreamed pattern like this we try to land on a single approach in order to have a more consistent appearance between pages that use this pattern, and to simplify the appearance. But we can easily pass a prop for image position as well. |
|
Discussed aspect ratio with @lyubomir-popov . When the image is full-width, it should generally use cinematic aspect ratio rather than 16:9 in order to avoid creating an extremely tall image. However, there is a possible use case for using 16:9 full width images: video embeds. |
a609c7a to
36d4328
Compare
|
There are a few examples that appear to be visually identical, such as: |
|
this was closed unintentionally by GitHub automation image template 1.6.0 has released - updating this now to clean up how the images are generated. |
cee78f9 to
2f32fec
Compare
|
Updated image template is working like a charm - much happier with this API. Left to do:
My capacity is quite low at the moment - so I'll take this once #5560 , #5555 , #5529 , #5598 close |
|
This PR ended up getting stuck in backlog priority for me and I've had very little capacity to address it - as I'm switching teams I'm un-assigning myself and leaving it open for others to address, using this comment as a rough checklist for remaining tasks. |

Done
Fixes #5549
Fixes WD-22925
QA
media_placement="before_description"is used.Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots