fix: remove private-address from relation databags for Juju 4.0+ #2275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Juju 4.0 no longer includes
private-addressin the default relation databags. The Scenario testing framework was incorrectly including it for all Juju versions.Changes
Runtime.exec()to removeprivate-addressfrom all relation databags when simulating Juju 4.0+, applied after state deep-copy where both state and Juju version are availableRelation,SubordinateRelation, andPeerRelationdatabags (local unit, remote units, and peers)Example
The solution avoids modifying
Relationconstructors (where Juju version is unavailable) by processing databags post-deepcopy in the runtime where both state and version are accessible.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.