-
Notifications
You must be signed in to change notification settings - Fork 3
breaking(charm): Replace NGINX ingress with Traefik #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pedro-avalos
wants to merge
18
commits into
main
Choose a base branch
from
replace-ingress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
+ Coverage 89.20% 89.30% +0.09%
==========================================
Files 28 28
Lines 1390 1403 +13
Branches 1 4 +3
==========================================
+ Hits 1240 1253 +13
Misses 150 150
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
3f46b2f to
d7a0cef
Compare
d396194 to
be5eb2b
Compare
be5eb2b to
71b9ba4
Compare
RIP NGINX 🪦 - also remove hostname option
this allows us to retrieve TLS certificates
will be used to test ingress is working
71b9ba4 to
fcdac1e
Compare
fcdac1e to
19a7125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Resolves HWAPI-61
Testing
Integration tests
Manual testing steps:
uvx tox run -e integrationChecklist
Additional Notes
This PR adds
traefik-k8sandlegoas components to be deployed in the product Terraform modules. These are to ensure that we can pull in a TLS certificate (NGINX pulled it from a K8s secret, but we are moving towards using LEGO credentials).