feat: various rule enhancements and adjustments#174
feat: various rule enhancements and adjustments#174SecondSkoll wants to merge 8 commits intomainfrom
Conversation
| - '.' | ||
| - '[.!?,]' | ||
| tokens: | ||
| - '[a-z0-9][.](?:\s|$)' No newline at end of file | ||
| - '[.!?,](?:\s|$)' |
There was a problem hiding this comment.
This causes a suggestion for the heading # A, B, C - which we presumably don't want to happen.
There was a problem hiding this comment.
It's a suggestion level rule, and it was Daniele's decision to apply it to most common grammar. So this is implemented as directed.
| - '[a-z][.?!] {2,}[A-Z]' | ||
| - '[.?!] {2,}$' |
There was a problem hiding this comment.
Why would we ever want even a single space at the end of a line (regardless of what comes before the space)? It's common practice for tools such as pre-commit hooks to flag trailing whitespace, so maybe we should adopt the same rule?
There was a problem hiding this comment.
That's probably a separate discussion to the core of this issue - which is just that double spaces at the end of a line in MD renders a linebreak.
2 participants
Addresses #153 #152 #151 #150 #148 and #146