fix(gh-actions/build-debian): Run lrc on extracted source package #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran lrc on the git repository but it should be run on the extracted source package instead because we often vendor files during the source packaging step.
In some repos (e.g. authd) lrc reports hundreds of issues which would require substantial manual effort to fix and maintain. To avoid breaking the CI of existing packages, we decided not to run lrc by default. It can be enabled by setting the run-lrc input to true.
Contributor
Author
|
Tested in https://github.com/canonical/authd/actions/runs/21886157056/job/63181433169?pr=1253#step:3:9730 (where a lot of issues were found). |
Member
|
Imo, this shouldn't be excluded by |
We only need the source package to run lrc, so let's also run it if building the binary package is skipped.
hk21702
approved these changes
Feb 12, 2026
Member
hk21702
left a comment
hk21702
left a comment
There was a problem hiding this comment.
LGTM and appears to be working!
https://github.com/ubuntu/ubuntu-insights/actions/runs/21928041497/job/63410122186?pr=315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran lrc on the git repository but it should be run on the extracted source package instead because we often vendor files during the source packaging step.
Also makes running lrc opt-in to avoid breaking existing packages.
UDENG-8981