fix(gh-actions/build-debian): Set -euo pipefail in all steps#100
Merged
fix(gh-actions/build-debian): Set -euo pipefail in all steps#100
Conversation
The "Run lintian on sources" and "Run lintian on binaries" steps succeeded even if lintian exits with a non-zero exit code. Using `set -euo pipefail` fixes that. Let's use it consistently in all steps to avoid similar issues in the future.
adombeck
changed the title
3v1n0
approved these changes
Feb 9, 2026
Contributor
Author
adombeck
added a commit
that referenced
this pull request
Feb 9, 2026
Turns out that lintian already checks the licenses and it's really the issues found by lintian which we care about (at least that is what reviewers of uploads to the archive look at). We just have to make the build-debian action fail when lintian fails (done in #100) and pass `--fail-on error,warning` to lintian (possible via the `lintian` input).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Run lintian on sources" and "Run lintian on binaries" steps succeeded even if lintian exits with a non-zero exit code.
Using
set -euo pipefailfixes that. Let's use it consistently in all steps to avoid similar issues in the future.UDENG-8986