fix: filter other commands by name instead of type#369
Open
jonathan-conder wants to merge 1 commit intocanonical:mainfrom
Open
fix: filter other commands by name instead of type#369jonathan-conder wants to merge 1 commit intocanonical:mainfrom
jonathan-conder wants to merge 1 commit intocanonical:mainfrom
Conversation
jonathan-conder
force-pushed
the
fix/other-commands-missing
branch
from
c399d18 to
76921b7
Compare
jonathan-conder
changed the title
tigarmo
reviewed
Aug 5, 2025
Collaborator
tigarmo
left a comment
tigarmo
left a comment
There was a problem hiding this comment.
@jonathan-conder thank you for spotting this! Could you add a simple test?
jonathan-conder
force-pushed
the
fix/other-commands-missing
branch
from
76921b7 to
c431f25
Compare
Author
|
I modified an existing test to catch the issue. But I'm not sure it really makes sense to test for this particular issue now that it's fixed. At least I'd be surprised if there's a regression. |
Previously, a command like craft_appplication.command.TestCommand, which inherits from PackCommand, would omit the parent command in the "see also" section.
jonathan-conder
force-pushed
the
fix/other-commands-missing
branch
from
c431f25 to
b38fd03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a command like craft_appplication.command.TestCommand, which inherits from PackCommand, would omit the parent command in the "see also" section.
make lint && make test?