snap: Work around snap build issue with Go plugin #1265
+29
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go plugin fails if the version of the Go build snap is older than the Go version in go.mod (canonical/craft-parts#1447). Work around that by not using the Go plugin. We already override the build, so the only thing we have to do manually now is to set the GOBIN environment variable.
To be consistent with the snapcraft.yaml of the other brokers.
Commit 97bb85c updated snap/snapcraft.yaml but that change never made it to the broker variant branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go plugin fails if the version of the Go build snap is older than the Go version in go.mod (canonical/craft-parts#1447).
Work around that by not using the Go plugin. We already override the build, so the only thing we have to do manually now is to set the
GOBINenvironment variable.UDENG-9079