Fix device login URL being printed twice

[nooreldeensalah]

Closes #682

Current output for SSH login attempt after the fix

== Device Authentication ==
Access the link below and use the provided login code
https://www.google.com/device
        FNC-YVC-MMQX

[3v1n0]

What was the previous output?

I feel the fix belongs to the broker though.

[nooreldeensalah]

That is the previous output (main branch) on my local machine

== Device Authentication ==
Access "https://www.google.com/device" and use the provided login code
https://www.google.com/device
        BLY-FHF-KWXW

Do you have any specific suggestions or directions on how you'd like to see the fix implemented in the broker instead?

[nooreldeensalah]

Thanks for the insight. I've simplifed the PR by removing the device login URL from the label at the broker (because the content already contains the VerificationURI )

Here is the current output

== Device Authentication ==
Access the link below and use the provided login code
https://www.google.com/device
        FNC-YVC-MMQX

[3v1n0]

Note that this may require adjusting the e2e tests.

[nooreldeensalah]

Fixed the failing e2e broker tests and rebased with main

[adombeck]

Thanks a lot for the contribution!

The change looks good to me. There was just some confusion regarding the "e2e tests". @3v1n0 was referring to the tests in e2e-tests/ but they don't use the string that was changed, so we don't have to update them.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.26%. Comparing base (f40fcbe) to head (f6824e5).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   86.04%   85.26%   -0.78%     
==========================================
  Files          99      119      +20     
  Lines        6685     7669     +984     
  Branches      111      111              
==========================================
+ Hits         5752     6539     +787     
- Misses        877     1074     +197     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[adombeck]

Thanks again for the contribution and for addressing all the suggestions!