-
Notifications
You must be signed in to change notification settings - Fork 33
Fix issues reported by lintian #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
df4a7b9 to
a6d6a7a
Compare
96aefd1 to
7c30fbd
Compare
By default, our build-debian action runs lintian with `--fail-on error`. We had an upload of authd to universe rejected because of lintian warnings and pedantic messages. We missed those because the CI succeeded even though lintian also reported those issues there.
As indicated by lintian
lintian complained about it:
P: authd source: source-contains-prebuilt-javascript-object [docs/.sphinx/_static/js/bundle.js]
59ca05a to
ed5afd3
Compare
Updated with the help of
decopy --group-by copyright --output debian/copyright --exclude "license.*|copyright.*|copying.*|.*snapcraft.yaml"
and a lot of manual adjustments of the result.
Also adjusts debian/lrc.config and debian/source/lintian-overrides.
ed5afd3 to
dbba07a
Compare
| Files: vendor_rust/pin-project/* | ||
| License: Apache-2 | ||
|
|
||
| Files: vendor_rust/windows-core/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we could exclude those... Also isn't the rust filtering tool already doing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the directory is there but it only contains the Cargo.toml and an empty src/lib.rs file. I suspect that's what we get from the cargo vendor-filterer tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess we can just consider it as excluded files then
| vendor_rust/syn/LICENSE-APACHE | ||
| vendor_rust/syn/LICENSE-MIT | ||
|
|
||
| Files: vendor_rust/pin-project/.cargo-checksum.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot just be:
| Files: vendor_rust/pin-project/.cargo-checksum.json | |
| Files: vendor_rust/pin-project/* |
No description provided.