Add authctl user set-shell command
#1165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adombeck
force-pushed
the
939-set-shell
branch
2 times, most recently
from
eb3fed6 to
dfb2353
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 87.64% 86.08% -1.56%
==========================================
Files 90 97 +7
Lines 6222 6682 +460
Branches 111 111
==========================================
+ Hits 5453 5752 +299
- Misses 713 874 +161
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adombeck
force-pushed
the
939-set-shell
branch
from
dfb2353 to
ee39e97
Compare
3v1n0
reviewed
Feb 10, 2026
| } | ||
|
|
||
| // SetShell sets the shell for the given user. | ||
| func (m *Manager) SetShell(username, shell string) (warnings []string, err error) { |
Contributor
There was a problem hiding this comment.
Shouldn't we also check if the shell is allowed in /etc/shells?
3v1n0
reviewed
Feb 10, 2026
Comment on lines
+673
to
+675
| if err := m.db.SetShell(username, shell); err != nil { | ||
| return nil, err | ||
| } |
Contributor
There was a problem hiding this comment.
Why doing this regardless the next checks are failing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is based on #1087, please review and merge that first.
Allow users to change their shell.
Closes #939
UDENG-7089