Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 104 104
Lines 20814 20814
Branches 3254 3254
=======================================
Hits 17555 17555
- Misses 2817 2818 +1
+ Partials 442 441 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oreiche
force-pushed
the
oreiche/fix-linter-issues
branch
from
f4af570 to
6e514e0
Compare
tests/integration/test_ui.py
Outdated
| from tests.paths import local_test_environment, patch_data_dir, restore_data_dir | ||
|
|
||
| ORIGINAL_SUBPROCESS_RUN = subprocess.run | ||
| ORIGINAL_SUBPROCESS_RUN = ( # pylint: disable=invalid-name, useless-suppression |
There was a problem hiding this comment.
Why not fix the invalid-name instead?
There was a problem hiding this comment.
Fixing the name would cause older pylint versions (<4.0.0) to complain. Not sure if you want to maintain support for older linter versions (and for how long)?
There was a problem hiding this comment.
We do not need to support older pylint version. You can bump the linter ci to resolute in an additional commit for this PR.
There was a problem hiding this comment.
Dropped support for older pylint versions and added an additional commit bumping the linter ci to resolute. PTAL :)
oreiche
force-pushed
the
oreiche/fix-linter-issues
branch
from
6e514e0 to
7fbea47
Compare
|
#552 should land first. |
test_ui.py: Fix name style for function constants, which are deliberately not considered constants anymore. apport-valgrind: Remove contradicting control messages, which also triggers a false positive "useless-suppression" warning. kernel_oops: Remove invalid-name suppression, as the new pylint now correctly identifies those variables not to be constants.
oreiche
force-pushed
the
oreiche/fix-linter-issues
branch
from
7fbea47 to
24e7100
Compare
2 participants
test_ui.py:
Fix name style for function constants, which are
deliberately not considered constants anymore.
apport-valgrind:
Remove contradicting control messages, which also triggers
a false positive "useless-suppression" warning.
kernel_oops:
Remove invalid-name suppression, as the new pylint now
correctly identifies those variables not to be constants.