Skip to content

retrace: move the duplicate checks and bug updates into helper functions#542

Merged
bdrung merged 2 commits intocanonical:mainfrom
bdrung:retrace-refactor
Jun 20, 2025
Merged

retrace: move the duplicate checks and bug updates into helper functions#542
bdrung merged 2 commits intocanonical:mainfrom
bdrung:retrace-refactor

Conversation

@bdrung
Copy link
Member

@bdrung bdrung commented Jun 20, 2025

Pulling out the low hanging last commit of #297

@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.

Project coverage is 84.22%. Comparing base (ccb7242) to head (5f5bbfb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
bin/apport-retrace 7.14% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   84.23%   84.22%   -0.01%     
==========================================
  Files         104      104              
  Lines       20789    20792       +3     
  Branches     3254     3254              
==========================================
+ Hits        17511    17513       +2     
- Misses       2826     2827       +1     
  Partials      452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdrung
Copy link
Member Author

bdrung commented Jun 20, 2025

tests/system/test_apport_retrace.py tests apport-retrace by calling it and coverage does not see that. So I am ignoring the code coverage complain.

@bdrung bdrung merged commit 24e599a into canonical:main Jun 20, 2025
34 of 37 checks passed
@bdrung bdrung deleted the retrace-refactor branch June 20, 2025 12:41
@bdrung bdrung added this to the 2.34.0 milestone Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants