report: remove dead code from internal helper functions#541
Open
bdrung wants to merge 2 commits intocanonical:mainfrom
Open
report: remove dead code from internal helper functions#541bdrung wants to merge 2 commits intocanonical:mainfrom
bdrung wants to merge 2 commits intocanonical:mainfrom
Conversation
`Report.add_proc_info` will always set `proc_pid_fd`. So the helper function `_read_proc_link` is not needed any more.
`Report.add_proc_info` will always set `proc_pid_fd`. So the case for `dir_fd` being `None` in `_read_proc_file` can be dropped and the parameter `pid` will not be needed any more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
=======================================
Coverage 84.21% 84.21%
=======================================
Files 104 104
Lines 20778 20772 -6
Branches 3253 3251 -2
=======================================
- Hits 17498 17494 -4
+ Misses 2827 2826 -1
+ Partials 453 452 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report.add_proc_infowill always setproc_pid_fd. So the helper function_read_proc_linkis not needed any more. The case fordir_fdbeingNonein_read_proc_filecan be dropped and the parameterpidwill not be needed any more.