Updated pre-commit tools and bracketed reax version #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiaSpider-SIMaP
approved these changes
Oct 23, 2025
Collaborator
MattiaSpider-SIMaP
left a comment
MattiaSpider-SIMaP
left a comment
There was a problem hiding this comment.
Great! Noted.
Member
Author
|
Sweet, go ahead and click 'Rebase and merge' and the |
Collaborator
I don't see any 'Rebase and merge', I guess I dont have merge permission or I'm missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the pre-commit tools to newer versions so they have caught a few things that were missed before. I also updated the minimum python version to 3.10 (because this is the minimum for
tensorialanyway). In Py310 some things were changed (for example there is no need forUnionany more, you can just usea | bin place ofUnion[a, b]which makes things cleaner).