-
-
Notifications
You must be signed in to change notification settings - Fork 146
Fix: include package-lock.json in release commits #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: web <web@cameroncooke.com>
Ensures npm ci and workflows use a lockfile that matches the bumped package version.
commit: |
WalkthroughThe pull request contains a patch version bump from 1.15.0 to 1.15.1 across package.json and server.json, including both top-level and nested version references. Additionally, the release script has been refactored to introduce a Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Background/Details
The release script was run from a Linux environment. The prior sed -i '' usage is macOS/BSD-specific and would fail on GNU sed.
Also, npm version updates the lockfile package version fields; the release commit should include that change to keep the repo consistent.
Solution
Testing
Notes
Note
Bumps version to 1.15.1 and updates release script for GNU/BSD portability with improved dry-run and inclusion of package-lock.json in release commits.
1.15.1inpackage.json,package-lock.json, andserver.json(includingpackages[*].version).scripts/release.sh):sed_inplacefor GNU/BSD; use it for README version updates.runwrapper and--dry-runbehavior (skip clean check; skip workflow monitoring).package-lock.jsonin release commits; streamline git and npm commands.server.jsonupdate vianode -ewith interpolated${VERSION}; tag and push viarun.Written by Cursor Bugbot for commit 951fb5f. This will update automatically on new commits. Configure here.