Skip to content

Conversation

@bigludo7
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Publication of Fall'25 M4 public release of number-verification v2.1.0

Which issue(s) this PR fixes:

Fixes #214

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@github-actions
Copy link

github-actions bot commented Aug 27, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.01s
✅ API spectral 1 0 1.56s
✅ GHERKIN gherkin-lint 2 0 0.76s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.74s
✅ YAML yamllint 1 0 0.38s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hdamker
Copy link
Contributor

hdamker commented Sep 2, 2025

@bigludo7 please clarify the status of #94, close or set to draft if not part Fall25 (what I suppose) to create a clear situation for the release reviewers.

bigludo7 and others added 2 commits September 10, 2025 15:10
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@bigludo7
Copy link
Collaborator Author

Thanks @Kevsy - I've commited your 2 requests.

Comment on lines 230 to 232
message:
type: string
description: A human-readable description of what the event represents
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigludo7 in sim-swap @hdamker commented to go back to the previous model camaraproject/SimSwap#229 (comment)

we should do the same here

@bigludo7
Copy link
Collaborator Author

bigludo7 commented Sep 10, 2025

@bigludo7 in sim-swap @hdamker commented to go back to the previous model camaraproject/SimSwap#229 (comment)
we should do the same here

But for me, @fernandopradocabrillo, the request in the order was for the required section and not the properties section. Do I miss something?

@fernandopradocabrillo
Copy link
Collaborator

@bigludo7 in sim-swap @hdamker commented to go back to the previous model camaraproject/SimSwap#229 (comment)
we should do the same here

But for me, @fernandopradocabrillo, the request in the order was for the required section and not the properties section. Do I miss something?

@bigludo7 now you got me, I though the problem was the order of the properties because they are not aligned with the examples

@bigludo7
Copy link
Collaborator Author

@bigludo7 in sim-swap @hdamker commented to go back to the previous model camaraproject/SimSwap#229 (comment)
we should do the same here

But for me, @fernandopradocabrillo, the request in the order was for the required section and not the properties section. Do I miss something?

@bigludo7 now you got me, I though the problem was the order of the properties because they are not aligned with the examples

Let ask to our Guru - Herbert are we good to go for this one for M4 ? the required section order for the ErrorInfo is good but not the properties sorting. Thanks for guidance.

@hdamker
Copy link
Contributor

hdamker commented Sep 11, 2025

Let ask to our Guru - Herbert are we good to go for this one for M4 ? the required section order for the ErrorInfo is good but not the properties sorting. Thanks for guidance.

@bigludo7 @fernandopradocabrillo

The order should be same in

  • ErrorInfo.required
  • ErrorInfo.properties
  • and all examples using these schema

The correct order is status -> code -> message.

The reference is now in https://github.com/camaraproject/Commonalities/pull/517/files (the fix which aligns the order with the API Design Guide and which will go into Commonalities r3.4.)

You had exactly the right order in v2.0.0 of number-verification.

To avoid confusion of developers about an unnecessary change between NumberVerification v2.0.0 and v2.1.0 I strongly recommend that you fix the order also in ErrorInfo.properties before the M4 release, so that it is again the same as in v2.0.0

@bigludo7
Copy link
Collaborator Author

@fernandopradocabrillo @hdamker I reversed the order. A new PR was not required as main was in the right order.

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management 👏

Next steps for the team:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@bigludo7 bigludo7 merged commit 5659864 into main Sep 12, 2025
2 checks passed
@bigludo7 bigludo7 deleted the fix214 branch September 12, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release PR for Fall25 M4 milestone

5 participants