Release r2.1 with NSB v0.2.0-rc.1 and NSA v0.1.0-rc.1 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XunliYang
requested review from
a team,
DanXu-ChinaTelecom,
Kai-hw and
chinaunicomyangfan
as code owners
17 tasks
tanjadegroot
requested changes
Jan 23, 2026
Collaborator
tanjadegroot
left a comment
tanjadegroot
left a comment
There was a problem hiding this comment.
Hi all,
quite some comments on the new API
I recommend to
- change this to a DRAFT Release PR, do the changes on main in normal PRs.
- wait for the Release PRs of Commonalities and ICM to be available and do the relevant adjustments (if any)
- then re-open and resynch the Release PR only after all required changes are done
Collaborator
There was a problem hiding this comment.
r2.1 needs to be added to the table of contents at the top of the file.
Collaborator
There was a problem hiding this comment.
the Release information section
- the links need to be updater to r2.1
- the links for the new NSA API need to be added.
| As a specific rule, error `501 - NOT_IMPLEMENTED` can be only a possible error response if it is explicitly documented in the API. | ||
| version: wip | ||
| version: v0.1.0-rc.1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| version: v0.1.0-rc.1 | |
| version: 0.1.0-rc.1 |
| version: wip | ||
| version: v0.1.0-rc.1 | ||
| x-camara-commonalities: 0.6 |
Collaborator
There was a problem hiding this comment.
Spring26 APIs need to release against Commonalities 0.7 (and ICM 0.5), not 0.6. (0.4)
To align with Spring26 Commonalities and ICM the release PRs need to be available, but there is a small delay.
Alternatively you can check the scope issue of Commonalities and ICM to see which updates might apply to your API.
See
| As a specific rule, error `501 - NOT_IMPLEMENTED` can be only a possible error response if it is explicitly documented in the API. | ||
| version: wip | ||
| version: v0.2.0-rc.1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| version: v0.2.0-rc.1 | |
| version: 0.2.0-rc.1 |
| @@ -1,4 +1,4 @@ | |||
| Feature: CAMARA Network Slice Booking API vwip - Operation deleteSlice | |||
| Feature: CAMARA Network Slice Booking API v0.2.0-rc.1 - Operation deleteSlice | |||
Collaborator
There was a problem hiding this comment.
this is not the same operation(Id) as in the filename
| * It provides the API consumer with the ability to: | ||
| * reserve, dynamically provisioning, query, dynamically delete a slice with customized SLA assurance capabilities, customized service duration, expected slice covered locations. | ||
| * reserve, dynamically provisioning, query, dynamically delete a slice with customized SLA assurance capabilities, customized service duration, expected slice covered locations. | ||
| * manage user subscription to the network slices. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * manage user subscription to the network slices. | |
| * manage user subscription by assigning their devices to the network slices. |
| | 10 | API release numbering convention applied | M | M | M | M | Y | | | ||
| | 11 | Change log updated | M | M | M | M | Y | [link](/CHANGELOG.md) | | ||
| | 12 | Previous public release was certified | O | O | O | M | N | | | ||
| | 13 | API description (for marketing) | O | O | M | M | Y | [Wiki link]( https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/81166982/NetworkSliceBooking+API+description) | | |
Collaborator
There was a problem hiding this comment.
the Wiki page is not yet updated to include the assignment API (or a dedicated file could be done).
either put "N" in the checklist and update later, or create/update it before release.
| | 3 | Guidelines from ICM applied | O | M | M | M | Y | [r3.4](https://github.com/camaraproject/IdentityAndConsentManagement/releases/tag/r3.4) | | ||
| | 4 | API versioning convention applied | M | M | M | M | Y | v0.1.0-rc.1 | | ||
| | 5 | API documentation | M | M | M | M | Y | Embed documentation into API spec - [link](/code/API_definitions/network-slice-assignment.yaml) | | ||
| | 6 | User stories | O | O | O | M | Y | [UserStory for Network Slicing Booking](/documentation/API_documentation/NSA_User_Story.md) | |
Collaborator
There was a problem hiding this comment.
Suggested change
| | 6 | User stories | O | O | O | M | Y | [UserStory for Network Slicing Booking](/documentation/API_documentation/NSA_User_Story.md) | | |
| | 6 | User stories | O | O | O | M | Y | [UserStory for Network Slice Assignement](/documentation/API_documentation/NSA_User_Story.md) | |
| # API Readiness Checklist | ||
|
|
||
| Checklist for network-slicing-book v0.1.0 in r1.2 | ||
| Checklist for network-slicing-book v0.2.0-rc.1 in r2.1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| Checklist for network-slicing-book v0.2.0-rc.1 in r2.1 | |
| Checklist for network-slicing-booking v0.2.0-rc.1 in r2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Release r2.1 with network-slice-booking v0.2.0-rc.1 and network-slice-assignment v0.1.0-rc.1
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input