Skip to content
This repository was archived by the owner on Nov 19, 2020. It is now read-only.

Don't crash on disconnect#88

Closed
timhuff wants to merge 2 commits intocallstack:masterfrom
timhuff:patch-1
Closed

Don't crash on disconnect#88
timhuff wants to merge 2 commits intocallstack:masterfrom
timhuff:patch-1

Conversation

@timhuff
Copy link

@timhuff timhuff commented Feb 13, 2018

No description provided.

@TeruyaHaroldo
Copy link

@renanpupin

@thejoelw
Copy link
Contributor

thejoelw commented Apr 4, 2018

I can confirm this prevents android from crashing when cleanUpPublisher is called from onStreamDestroyed

@jukben
Copy link
Contributor

jukben commented Apr 23, 2018

Thanks for the PR. Is that somehow related to #89? @JWalker1995 @timhuff @HaroldoTeruya

@timhuff
Copy link
Author

timhuff commented Apr 23, 2018

I'm not sure. They seem to both be the result of resource management going wrong at some point. Wish I could remember because I recall thinking I had a decent idea of what was happening... oh! My guess was that OpenTok's new SDK starting releasing the resource and then on disconnect, you would, too. Like double freeing a pointer. I think I concluded that it was ultimately TokBox's fault. I can tell you, though, that this fix has been deployed to thousands of users (who each have to use the app several times a day) without complaint for about 2 months now.

Copy link

@infothien infothien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix my problem crash on Android phone when run Opentok.disconnect(SessionId). Please check it!

@timhuff
Copy link
Author

timhuff commented May 8, 2018

Looks like the repo has implemented an equivalent change since this pull request was created.

@timhuff timhuff closed this May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants