upgrade to cake 5.1 and code smells#67
Open
AdaskoTheBeAsT wants to merge 1 commit intocake-contrib:mainfrom
Open
upgrade to cake 5.1 and code smells#67AdaskoTheBeAsT wants to merge 1 commit intocake-contrib:mainfrom
AdaskoTheBeAsT wants to merge 1 commit intocake-contrib:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the project to Cake 5.1 and addresses various code quality issues across the test suite. The primary goals are dependency updates, improved code consistency, and better adherence to coding standards.
- Upgraded NuGet package dependencies to their latest versions (Cake.Core and Cake.Testing to 5.1.0, Microsoft.NET.Test.Sdk to 18.0.0, xunit.runner.visualstudio to 3.1.5)
- Refactored test fixtures to use object initializer syntax for better readability and consistency
- Fixed collection initialization syntax by adding missing commas and correcting formatting issues
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Cake.MsDeploy/Cake.MsDeploy.csproj | Updated Cake.Core package reference from 5.0.0 to 5.1.0 |
| src/Cake.MsDeploy.Tests/Cake.MsDeploy.Tests.csproj | Updated multiple NuGet package versions including test frameworks |
| src/Cake.MsDeploy.Tests/Unit/MsDeployRunnerTests.cs | Refactored test fixtures to use object initializer syntax and fixed collection formatting |
| src/Cake.MsDeploy.Tests/Unit/Providers/MsDeployProviderTests.cs | Reorganized using statements, fixed collection initializations, and cleaned up code formatting |
| src/Cake.MsDeploy.Tests/Unit/Rules/ReplacementRuleTests.cs | Added null-forgiving operator, removed extra whitespace, and fixed assertion parameters |
| src/Cake.MsDeploy.Tests/Unit/Parameters/SetParameterTests.cs | Reorganized using statements, made class static, and fixed collection syntax |
| src/Cake.MsDeploy.Tests/Unit/Parameters/DeclareParameterTests.cs | Similar improvements to parameter test classes with reorganized imports and syntax fixes |
| src/Cake.MsDeploy.Tests/Unit/MsDeployAliasesTests.cs | Added null-forgiving operators and improved assertion parameter usage |
| src/Cake.MsDeploy.Tests/Unit/Directives/SkipDIrectiveTests.cs | Reorganized using statements, made class static, and fixed collection syntax |
| Cake.MsDeploy.slnx | Added .props folder structure to include configuration files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates and improves the test code for the
Cake.MsDeployproject. The main changes include upgrading NuGet package dependencies, refactoring test setup for clarity and consistency, and making minor code style and correctness improvements in the test files.Dependency updates:
Cake.MsDeploy.Tests.csproj, includingCake.CoreandCake.Testingto version 5.1.0,Microsoft.NET.Test.Sdkto 18.0.0, andxunit.runner.visualstudioto 3.1.5.Test code refactoring and improvements:
MsDeployRunnerTests.csto use object initializer syntax, improving readability and consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Code style and correctness fixes:
null!) for clarity and to avoid warnings. [1] [2] [3] [4]Project structure:
.propsfolder in the solution file to include configuration files like.editorconfig,.gitattributes, and.gitignore.