Added plugin/widget for website and local time #2
Conversation
…omo-org#21926) * [Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.* * Apply coding style around FunctionCallSignature #1 (matomo-org#21927) * Apply coding style around FunctionCallSignature #2 (matomo-org#21928) * Apply coding style around FunctionCallSignature #3 (matomo-org#21929) * Apply coding style around FunctionCallSignature #4 (matomo-org#21930) * Apply coding style around FunctionCallSignature #5 (matomo-org#21931) * Apply coding style around FunctionCallSignature matomo-org#6 (matomo-org#21932) * Apply coding style around FunctionCallSignature matomo-org#7 (matomo-org#21933) * Apply coding style around FunctionCallSignature matomo-org#8 (matomo-org#21934) * Apply coding style around FunctionCallSignature matomo-org#9 (matomo-org#21935)
|
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
|
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
|
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
Created a new plugin and a widget for displaying the website time and/or the locale time.
When timezones are the same:
When they are different:
I ran out of time for tests, if I had more time I would test the following:
WebsiteAndLocalTime.render()method, an integration test due to static calls to other classes that I can't mock. The test would make sure the correct timezone is returned.To Fix:
With more time I would change to pass around the UTC offset and compare that value instead.
Also I would take more time to learn about the design system to make the content of the widget look nicer, for now I just focussed on it looking good enough.