Add stereo image #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roystormstout
approved these changes
Oct 11, 2019
Collaborator
roystormstout
left a comment
roystormstout
left a comment
There was a problem hiding this comment.
resolved config file conflict
ZXCroon
approved these changes
Oct 11, 2019
eddylan2894
commented
Oct 18, 2019
irmark1/parts/controller.py
Outdated
|
|
||
|
|
||
| def run_threaded(self, img_arr=None): | ||
| def run_threaded(self, img_arr=None, rear_img_arr=None): |
Contributor
Author
There was a problem hiding this comment.
Is the rear_img_arr used?
Collaborator
There was a problem hiding this comment.
It isn't used yet. The reason I put it here is that I thought in the future we would need rear_img in autonomous driving. Since we have agreed that we don't need it, you can remove this part.
eddylan2894
commented
Oct 18, 2019
irmark1/templates/complete.py
Outdated
|
|
||
| V.add(camA, outputs=['cam/image_array_a'], threaded=True) | ||
| V.add(camB, outputs=['cam/image_array_b'], threaded=True) | ||
| if cfg.CAMERA_TYPE == "NANO-MARK1": |
Contributor
Author
There was a problem hiding this comment.
Change name to "MARK1" and move it below (not stereo).
eddylan2894
commented
Oct 18, 2019
irmark1/templates/complete.py
Outdated
| else: | ||
| V.add(cam, inputs=inputs, outputs=['cam/image_array'], threaded=threaded) | ||
| from irmark1.parts.image import Duplicator | ||
| V.add(Duplicator(2), inputs=['cam/image_array'], outputs=['cam/image_array_a', 'cam/image_array_b']) |
Contributor
Author
There was a problem hiding this comment.
Shouldn't use duplicator in drive.
Collaborator
There was a problem hiding this comment.
No we shouldn't. This part is basically designed for validating that the dual camera work. If we have confirmed that, we could remove it.
eddylan2894
commented
Oct 18, 2019
irmark1/parts/camera.py
Outdated
| ''' | ||
| def gstreamer_pipeline(self, capture_width=3280, capture_height=2464, output_width=224, output_height=224, framerate=21, flip_method=0) : | ||
| return 'nvarguscamerasrc ! video/x-raw(memory:NVMM), width=%d, height=%d, format=(string)NV12, framerate=(fraction)%d/1 ! nvvidconv flip-method=%d ! nvvidconv ! video/x-raw, width=(int)%d, height=(int)%d, format=(string)BGRx ! videoconvert ! appsink' % ( | ||
| return 'nvarguscamerasrc sensor-id=0 ! video/x-raw(memory:NVMM), width=%d, height=%d, format=(string)NV12, framerate=(fraction)%d/1 ! nvvidconv flip-method=%d ! nvvidconv ! video/x-raw, width=(int)%d, height=(int)%d, format=(string)BGRx ! videoconvert ! appsink' % ( |
Contributor
Author
There was a problem hiding this comment.
not neccessary?
eddylan2894
force-pushed
the
add_stereo_image
branch
2 times, most recently
from
946110d to
1bada75
Compare
eddylan2894
force-pushed
the
add_stereo_image
branch
from
1bada75 to
97a2baf
Compare
eddylan2894
force-pushed
the
add_stereo_image
branch
from
ecfd458 to
4fc623c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review Carl and Eddy's code